-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TaskProcessing): Implement enums and default values #46722
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
799ee8f
feat(TaskProcessing): Implement enums and default values
marcelklehr 060fb26
fix(taskprocessing): run cs:fix
julien-nc 0584ebf
fix(taskprocessing): add license
julien-nc a2e531c
fix(taskprocessing): fix OpenAPI error and generate specs
julien-nc c23f126
fix(taskprocessing): fix cs issues and generate autoloaders
julien-nc 9306dde
fix(taskprocessing): fix psalm issue
julien-nc 6363437
fix(taskprocessing): Update lib/private/TaskProcessing/Manager.php
marcelklehr aaa8af4
fix: Make sure provider provides enum values
marcelklehr 46c518f
fix: Don't validate input again upon running a task
marcelklehr 5ed55b0
feat(taskprocessing): add translate task type
julien-nc 0b04a6a
fix(taskprocessing): fix typo in text2text task type
julien-nc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
102 changes: 102 additions & 0 deletions
102
lib/public/TaskProcessing/TaskTypes/TextToTextTranslate.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/** | ||
* SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors | ||
* SPDX-License-Identifier: AGPL-3.0-or-later | ||
*/ | ||
|
||
namespace OCP\TaskProcessing\TaskTypes; | ||
|
||
use OCP\IL10N; | ||
use OCP\L10N\IFactory; | ||
use OCP\TaskProcessing\EShapeType; | ||
use OCP\TaskProcessing\ITaskType; | ||
use OCP\TaskProcessing\ShapeDescriptor; | ||
|
||
/** | ||
* This is the task processing task type for generic text processing | ||
* @since 30.0.0 | ||
*/ | ||
class TextToTextTranslate implements ITaskType { | ||
/** | ||
* @since 30.0.0 | ||
*/ | ||
public const ID = 'core:text2text:translate'; | ||
|
||
private IL10N $l; | ||
|
||
/** | ||
* @param IFactory $l10nFactory | ||
* @since 30.0.0 | ||
*/ | ||
public function __construct( | ||
IFactory $l10nFactory, | ||
) { | ||
$this->l = $l10nFactory->get('core'); | ||
} | ||
|
||
|
||
/** | ||
* @inheritDoc | ||
* @since 30.0.0 | ||
*/ | ||
public function getName(): string { | ||
return $this->l->t('Translate'); | ||
} | ||
|
||
/** | ||
* @inheritDoc | ||
* @since 30.0.0 | ||
*/ | ||
public function getDescription(): string { | ||
return $this->l->t('Translate text from one language to another'); | ||
} | ||
|
||
/** | ||
* @return string | ||
* @since 30.0.0 | ||
*/ | ||
public function getId(): string { | ||
return self::ID; | ||
} | ||
|
||
/** | ||
* @return ShapeDescriptor[] | ||
* @since 30.0.0 | ||
*/ | ||
public function getInputShape(): array { | ||
return [ | ||
'input' => new ShapeDescriptor( | ||
$this->l->t('Origin text'), | ||
$this->l->t('The text to translate'), | ||
EShapeType::Text | ||
), | ||
'origin_language' => new ShapeDescriptor( | ||
$this->l->t('Origin language'), | ||
$this->l->t('The language of the origin text'), | ||
EShapeType::Enum | ||
), | ||
'target_language' => new ShapeDescriptor( | ||
$this->l->t('Target language'), | ||
$this->l->t('The desired language to translate the origin text in'), | ||
EShapeType::Enum | ||
), | ||
]; | ||
} | ||
|
||
/** | ||
* @return ShapeDescriptor[] | ||
* @since 30.0.0 | ||
*/ | ||
public function getOutputShape(): array { | ||
return [ | ||
'output' => new ShapeDescriptor( | ||
$this->l->t('Result'), | ||
$this->l->t('The translated text'), | ||
EShapeType::Text | ||
), | ||
]; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.