Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(files_sharing): open-in-files should open a folder and not the parent #46755

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 25, 2024

Backport of #46648

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge, skjnldsv and susnux July 25, 2024 13:44
@backportbot backportbot bot added this to the Nextcloud 29.0.5 milestone Jul 25, 2024
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 27, 2024
@skjnldsv skjnldsv force-pushed the backport/46648/stable29 branch from bd7dab4 to 75bbb54 Compare August 2, 2024 07:04
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 2, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Aug 2, 2024

/compile rebase-amend /

@skjnldsv skjnldsv marked this pull request as ready for review August 2, 2024 07:05
@skjnldsv skjnldsv enabled auto-merge August 2, 2024 07:06
@nextcloud-command nextcloud-command force-pushed the backport/46648/stable29 branch from 75bbb54 to e9dd63b Compare August 2, 2024 07:13
@skjnldsv skjnldsv force-pushed the backport/46648/stable29 branch 2 times, most recently from 1b4d94c to d1ba704 Compare August 2, 2024 08:02
@skjnldsv
Copy link
Member

skjnldsv commented Aug 2, 2024

TypeError: e(...).findByRole is not a function

@skjnldsv
Copy link
Member

skjnldsv commented Aug 2, 2024

WWill rebase after #46529, that should fix it 👍

susnux and others added 4 commits August 2, 2024 15:44
…parent

For files this behavior is fine, but for folders the folder itself should be opened.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the backport/46648/stable29 branch from d1ba704 to 0523fad Compare August 2, 2024 13:44
@skjnldsv skjnldsv merged commit 12e6f0f into stable29 Aug 2, 2024
110 checks passed
@skjnldsv skjnldsv deleted the backport/46648/stable29 branch August 2, 2024 14:18
@Altahrim Altahrim mentioned this pull request Aug 8, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants