Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TaskProcessing): Catch JSON encode errors in Manager#setTaskResult #46780

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix(TaskProcessing): Catch JSON encode errors in Manager#setTaskResult #46780

merged 1 commit into from
Jan 24, 2025

Conversation

marcelklehr
Copy link
Member

Checklist

bigcat88
bigcat88 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@marcelklehr marcelklehr force-pushed the fix/taskprocessing-better-errors branch 2 times, most recently from 714e495 to da34d4c Compare July 26, 2024 12:00
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 26, 2024
View reviewed changes
@skjnldsv skjnldsv marked this pull request as draft November 15, 2024 13:07
@marcelklehr marcelklehr force-pushed the fix/taskprocessing-better-errors branch from da34d4c to 975a0e7 Compare January 23, 2025 08:27
@marcelklehr marcelklehr marked this pull request as ready for review January 23, 2025 08:27
@marcelklehr marcelklehr force-pushed the fix/taskprocessing-better-errors branch from 975a0e7 to 4fc0369 Compare January 23, 2025 10:41
@marcelklehr
Copy link
Member Author

/backport to stable31

@marcelklehr
Copy link
Member Author

/backport to stable30

@marcelklehr marcelklehr merged commit d7ce5d4 into master Jan 24, 2025
190 checks passed
@marcelklehr marcelklehr deleted the fix/taskprocessing-better-errors branch January 24, 2025 08:14
This was referenced Jan 24, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigcat88 bigcat88 bigcat88 approved these changes

@kyteinsky kyteinsky kyteinsky approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelklehr @bigcat88 @kyteinsky