refactor(files): Drop unneeded initial state #47016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
feature: files
♻️ refactor
skjnldsv
approved these changes
Aug 3, 2024
skjnldsv
requested review from
a team,
Fenn-CS,
szaimen and
sorbaugh
and removed request for
a team
Merged
|
/compile |
nextcloud-command
requested review from
provokateurin,
ChristophWurst,
miaulalala,
nickvergessen,
st3iny,
come-nc and
tcitworld
as code owners
|
The rebase broke |
That was the UI toggle 👀 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -42,13 +42,21 @@ | |||
| public function run(): SetupResult { | |||
| $datadir = str_replace(\OC::$SERVERROOT . '/', '', $this->config->getSystemValue('datadirectory', '')); | |||
|
|
|||
| $dataUrl = $this->urlGenerator->getWebroot() . '/' . $datadir . '/.ocdata'; | |||
| $dataUrl = $this->urlGenerator->getWebroot() . '/' . $datadir . '/.ncdata'; | |||
Check notice
Code scanning / Psalm
PossiblyInvalidOperand Note
susnux
force-pushed
the
refactor/cleanup-files-view
branch
from
cc9b030
to
c6c919a
Compare
susnux
removed request for
miaulalala,
nickvergessen,
st3iny,
come-nc and
tcitworld
|
Fixed. |
|
/compile |
st3iny
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Looks good.
To make eslint happy:
diff --git a/apps/files/src/components/FilesListVirtual.vue b/apps/files/src/components/FilesListVirtual.vue
index f0ac8ba3d70..cb38d744738 100644
--- a/apps/files/src/components/FilesListVirtual.vue
+++ b/apps/files/src/components/FilesListVirtual.vue
@@ -64,7 +64,6 @@ import type { UserConfig } from '../types'
import { getFileListHeaders, Folder, View, getFileActions, FileType } from '@nextcloud/files'
import { showError } from '@nextcloud/dialogs'
-import { loadState } from '@nextcloud/initial-state'
import { translate as t } from '@nextcloud/l10n'
import { defineComponent } from 'vue'
@@ -198,7 +197,7 @@ export default defineComponent({
},
openFile: {
- handler(open: boolean) {
+ handler() {
// wait for scrolling and updating the actions to settle
this.$nextTick(() => {
if (this.fileId && this.openFile) {
The initial state is no longer used, it was only used in legacy UI and in the f2v rewrite it was only used for the `id` which can be loaded just from the URL. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsv
force-pushed
the
refactor/cleanup-files-view
branch
from
600d9de
to
46bb8ef
Compare
|
/backport to stable29 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The initial state is no longer used, it was only used in legacy UI and in the f2v rewrite it was only used for the
idwhich can be loaded just from the URL.Checklist