fix(files): Disable tags editing for shared files/folders with view only permission #47149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly permission Signed-off-by: Konstantin Myakshin <molodchick@gmail.com>
|
/compile / |
4 tasks
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsv
approved these changes
Aug 9, 2024
skjnldsv
added
4. to release
susnux
approved these changes
Aug 9, 2024
nextcloud-command
approved these changes
Aug 9, 2024
|
@Koc Merged! Thanks for the fix! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicating #46663 to run all actions
How to reproduce
Expected result: user not able remove/add tags
Actual result: user able remove/add tags on UI (we have http 403 on the server side, but UI allows this actions)
🔍 Folder details for admin
🔍 Folder details for user
Checklist