Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Security): Allow defining a password context for password validation and generation #47403

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 21, 2024

Summary

This would allow us to implement nextcloud/password_policy#117.
Basically add a context to the events to define for which use case the password needs to be validated / generated.

Checklist

@susnux susnux added enhancement 3. to review Waiting for reviews labels Aug 21, 2024
@susnux susnux added this to the Nextcloud 31 milestone Aug 21, 2024
@susnux susnux force-pushed the feat/password-context branch from 182d206 to f7e5464 Compare August 21, 2024 18:28
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool otherwise

lib/public/Security/Events/ValidatePasswordPolicyEvent.php Outdated Show resolved Hide resolved
lib/public/Security/PasswordContext.php Outdated Show resolved Hide resolved
@susnux susnux force-pushed the feat/password-context branch from 9a4f377 to 14588fb Compare August 21, 2024 19:25
@susnux susnux requested a review from nickvergessen August 21, 2024 19:27
@susnux susnux force-pushed the feat/password-context branch from 14588fb to dae0f9a Compare August 21, 2024 19:58
@nickvergessen nickvergessen added the pending documentation This pull request needs an associated documentation update label Aug 21, 2024
susnux and others added 2 commits August 22, 2024 19:16
…eration

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/password-context branch from dae0f9a to dd58e52 Compare August 22, 2024 17:17
@susnux susnux merged commit 920a741 into master Aug 22, 2024
171 checks passed
@susnux susnux deleted the feat/password-context branch August 22, 2024 22:01
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement pending documentation This pull request needs an associated documentation update 🍀 2025-Spring
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

5 participants