-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Security): Allow defining a password context for password validation and generation #47403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nickvergessen,
skjnldsv,
provokateurin and
come-nc
August 21, 2024 18:28
susnux
force-pushed
the
feat/password-context
branch
from
August 21, 2024 18:28
182d206
to
f7e5464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool otherwise
susnux
force-pushed
the
feat/password-context
branch
from
August 21, 2024 19:25
9a4f377
to
14588fb
Compare
susnux
force-pushed
the
feat/password-context
branch
from
August 21, 2024 19:58
14588fb
to
dae0f9a
Compare
nickvergessen
approved these changes
Aug 21, 2024
nickvergessen
added
the
pending documentation
This pull request needs an associated documentation update
label
Aug 21, 2024
provokateurin
approved these changes
Aug 21, 2024
come-nc
reviewed
Aug 22, 2024
…eration Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/password-context
branch
from
August 22, 2024 17:17
dae0f9a
to
dd58e52
Compare
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
pending documentation
This pull request needs an associated documentation update
🍀 2025-Spring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This would allow us to implement nextcloud/password_policy#117.
Basically add a context to the events to define for which use case the password needs to be validated / generated.
Checklist