Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 22, 2024

Pending PRs:

@skjnldsv skjnldsv self-assigned this Aug 22, 2024
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Aug 22, 2024
@skjnldsv skjnldsv added this to the Nextcloud 30 milestone Aug 22, 2024
@susnux
Copy link
Contributor

susnux commented Aug 22, 2024

Would be good to include #47249 as there is a later migration for the same table already back ported 🙈

@skjnldsv
Copy link
Member Author

Would be good to include #47249 as there is a later migration for the same table already back ported 🙈

Address Joas's comment and we can get it in before release 👍

@susnux
Copy link
Contributor

susnux commented Aug 22, 2024

Address Joas's comment and we can get it in before release 👍

Done, I think it is just meta data.

It is already merged like that in master, not sure if it makes more sense to fix master and backport that annotation later.
(Especially as I currently have no clue what that is doing due to lack of documentation)
But also other migrations for 30 have already been backported without annotations, so maybe as said do that as a follow up for RC3?

@skjnldsv
Copy link
Member Author

/compile rebase /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 22, 2024
skjnldsv and others added 2 commits August 22, 2024 13:56
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 1e7affa into stable30 Aug 22, 2024
@skjnldsv skjnldsv deleted the release/30.0.0_rc2 branch August 22, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants