-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove circle name from share's recipient's e-mail notification #1422
base: master
Are you sure you want to change the base?
Remove circle name from share's recipient's e-mail notification #1422
Conversation
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
While I like the idea, the result might not be the expected one, the sentence itself needs some change |
@ArtificialOwl could you help me by giving some more information about the needed changes ? |
maybe ending the sentence by "with you" ? instead of "with (empty)" |
To keep the discussion in one place, let’s maybe continue in the issue where I posted a suggestion already: #1239 (comment) |
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> Remove circle name from share's recipient's e-mail notification Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
e4cc5b0
to
5fb7ac3
Compare
Check last commit, following discussion with @jancborchardt in #1239 |
May ...
Fix: #1239
Not sure if it's enough and correct from a syntax point of view ; I would need reviewers to test it by their side.
The goal is just to remove the circle's name from the e-mail that the recipient receives because circle's name is not his business and should be kept private.
Thanks