Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(admin_audit): add test for user management listener #47414

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Aug 22, 2024

  • Resolves: technical debt

Summary

The migration to event listener was done by #47865.

Good bye hooks, hello event listener (at least for one case)

Test cases:

- Enable admin_audit
- Enable user => see log line in audit log
- Change email for user => see log line in audit log

TODO

  • CI
  • Review
  • Merge

Checklist

@kesselb kesselb added 3. to review Waiting for reviews technical debt labels Aug 22, 2024
@kesselb kesselb added this to the Nextcloud 31 milestone Aug 22, 2024
@kesselb kesselb self-assigned this Aug 22, 2024
@come-nc
Copy link
Contributor

come-nc commented Sep 14, 2024

@kesselb conflicts 😉

@kesselb kesselb force-pushed the debt/noid/user-changed-event branch from d30b988 to 83ad425 Compare September 16, 2024 08:51
@kesselb kesselb changed the title refactor: use event listener instead of user changed hook test(admin_audit): add test for user management listener Sep 16, 2024
@kesselb
Copy link
Contributor Author

kesselb commented Sep 16, 2024

@come-nc resolved 🎉

@kesselb kesselb force-pushed the debt/noid/user-changed-event branch from 83ad425 to 9791084 Compare September 23, 2024 10:52
@kesselb kesselb requested review from a team, Altahrim, nfebe and provokateurin and removed request for a team September 23, 2024 10:52
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the debt/noid/user-changed-event branch from 9791084 to 5cf67c2 Compare September 23, 2024 11:06
@blizzz blizzz merged commit b3ca5b5 into master Oct 2, 2024
173 checks passed
@blizzz blizzz deleted the debt/noid/user-changed-event branch October 2, 2024 09:25
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants