Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): Add setup check for apcu cache expunge #47507

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 27, 2024

Summary

This adds a basic setup check to warn admins if their APCu cache is close to be full or has been expunged. Ideally we would be able to calculate something like a rate for how long the cache is kept until cleaned up, but i couldn't find a reasonable metric and we cannot get the startup time of the php service itself.

Checklist

@juliusknorr juliusknorr force-pushed the feat/apcu-setup-check branch from e3cd7dc to 94da937 Compare August 27, 2024 07:14
@juliusknorr juliusknorr added enhancement 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update performance 🚀 labels Aug 27, 2024
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the feat/apcu-setup-check branch from 3347249 to f3419c5 Compare August 27, 2024 08:45
@juliusknorr juliusknorr requested review from nickvergessen, a team, artonge, skjnldsv and come-nc and removed request for a team August 27, 2024 08:45
@skjnldsv
Copy link
Member

Nice!

@juliusknorr juliusknorr merged commit b8b5f2c into master Aug 27, 2024
169 of 171 checks passed
@juliusknorr juliusknorr deleted the feat/apcu-setup-check branch August 27, 2024 13:18
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that apply to cli as well? Remember that setupchecks can be run by occ and in this case they use the php cli ini file which is not configured the same as web.

@juliusknorr
Copy link
Member Author

Right, we cannot really check in cli as there is no shared memory with what ever SAPI is used.

@come-nc
Copy link
Contributor

come-nc commented Aug 29, 2024

Right, we cannot really check in cli as there is no shared memory with what ever SAPI is used.

Then the check should check the CLI flag and bail out, take inspiration from other php config related checks.

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement pending documentation This pull request needs an associated documentation update performance 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup check for apcu cache statistics
4 participants