-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(settings): Add setup check for apcu cache expunge #47507
Conversation
e3cd7dc
to
94da937
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
3347249
to
f3419c5
Compare
Nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that apply to cli as well? Remember that setupchecks can be run by occ and in this case they use the php cli ini file which is not configured the same as web.
Right, we cannot really check in cli as there is no shared memory with what ever SAPI is used. |
Then the check should check the CLI flag and bail out, take inspiration from other php config related checks. |
Summary
This adds a basic setup check to warn admins if their APCu cache is close to be full or has been expunged. Ideally we would be able to calculate something like a rate for how long the cache is kept until cleaned up, but i couldn't find a reasonable metric and we cannot get the startup time of the php service itself.
Checklist