Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logger): ignore session logging during setup #47521

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix(logger): ignore session logging during setup #47521

merged 1 commit into from
Aug 27, 2024

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Aug 27, 2024 •
edited
Loading

This fix a regression from #47105 that lock installation process on 29.0.5 (but no 30 😕 ) when using the web interface

@ArtificialOwl ArtificialOwl mentioned this pull request Aug 27, 2024
Merged
@nickvergessen
Copy link
Member

Or we wrap the code with an isInstalled() check?

@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Aug 27, 2024 •
edited
Loading

if we can ignore slow session logging during installation process, I could check this in base.php and send a null logger to the Session

nickvergessen
nickvergessen approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both makes sense.

@ArtificialOwl ArtificialOwl force-pushed the fix/noid/loosing-systemconfig-on-setup branch from d0f57b5 to 509e3f1 Compare August 27, 2024 12:55
@ArtificialOwl
Copy link
Member Author

@nickvergessen please check this new way of fixing the issue.

@ArtificialOwl
fix(setup): ignore long session login during installation
9100b87 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/loosing-systemconfig-on-setup branch from 509e3f1 to 9100b87 Compare August 27, 2024 13:30
@ArtificialOwl
Copy link
Member Author

Thanks. Fixed, squashed and rebased

@ArtificialOwl
Copy link
Member Author

/backport to stable30

@ArtificialOwl
Copy link
Member Author

/backport to stable29

@ArtificialOwl
Copy link
Member Author

(no idea if an urgent new release of 29 is needed)

@ArtificialOwl ArtificialOwl changed the title fix(logger): ignore appcontainer for core fix(logger): ignore session logging during setup Aug 27, 2024
@solracsf solracsf added this to the Nextcloud 31 milestone Aug 27, 2024
@ArtificialOwl ArtificialOwl merged commit e68f77e into master Aug 27, 2024
171 checks passed
@ArtificialOwl ArtificialOwl deleted the fix/noid/loosing-systemconfig-on-setup branch August 27, 2024 19:10
This was referenced Aug 27, 2024
Merged
Merged
@joshtrichards
Copy link
Member

joshtrichards commented Aug 27, 2024 •
edited
Loading

Confirmed that this fixes nextcloud/docker#2283

@joshtrichards
Copy link
Member

joshtrichards commented Aug 27, 2024 •
edited
Loading

(no idea if an urgent new release of 29 is needed)

This breaks web based installations. While occ maintenance:install is a workaround, this is a serious bug. There are reports on the community forum as well. I think we need to do a new release.

This was referenced Aug 27, 2024
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@artonge artonge artonge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
6 participants
@ArtificialOwl @nickvergessen @joshtrichards @AndyScherzinger @artonge @solracsf