[TaskProcessing] Use taskprocessing in TextProcessing and STT managers #47601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
requested review from
marcelklehr,
AndyScherzinger,
bigcat88 and
kyteinsky
|
/backport to stable30 |
AndyScherzinger
approved these changes
Aug 29, 2024
AndyScherzinger
approved these changes
Aug 29, 2024
julien-nc
force-pushed
the
enh/noid/use-taskprocessing-in-old-managers
branch
from
0adf57a to
3d250e5
Compare
julien-nc
force-pushed
the
enh/noid/use-taskprocessing-in-old-managers
branch
from
3d250e5 to
a5218a7
Compare
marcelklehr
reviewed
Aug 29, 2024
marcelklehr
reviewed
Aug 29, 2024
julien-nc
force-pushed
the
enh/noid/use-taskprocessing-in-old-managers
branch
2 times, most recently
from
e709ea5 to
ae6f15c
Compare
…singManager::runTask Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…rocessingManager::runTask Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net> Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net> Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
taskprocessing is transparent to STT providers so specific STT settings are obsolete Signed-off-by: Marcel Klehr <mklehr@gmx.net> Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…rocessing settings TaskProcessing is transparent to textprocessing providers and TextProcessing can use Taskprocessing providers so these are unnecessary Signed-off-by: Marcel Klehr <mklehr@gmx.net> Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…ilable Signed-off-by: Marcel Klehr <mklehr@gmx.net> Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net> Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…ethods" This reverts commit d624c8d. Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/use-taskprocessing-in-old-managers
branch
from
ae6f15c to
95006d2
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
a task processing task actually runs. So these old APIs still benefit from the new task processing providers.
@marcelklehr Like we discussed, it might be good to remove the AI admin settings STT section and adjust the text processing one so it does not show preferences for
FreePromptTaskType,HeadlineTaskType,SummaryTaskTypeandTopicsTaskType.Also, @marcelklehr Should we only run the task processing task in those manager's "run" methods and get rid of the 2nd part which still runs the task like before in case the task processing task has failed?