Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_external): broken credentials dialog #47945

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

skjnldsv
Copy link
Member

The browsers behavior changed and some stopped prompting the native browser auth dialog on xhr requests.

This replaces it with a proper dialog.
Fix #44497

2024-09-13_12-00

@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Sep 13, 2024
@skjnldsv skjnldsv requested review from provokateurin and a team September 13, 2024 12:01
@skjnldsv skjnldsv self-assigned this Sep 13, 2024
@skjnldsv skjnldsv requested review from susnux, artonge and Pytal and removed request for a team September 13, 2024 12:01
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@skjnldsv skjnldsv force-pushed the fix/external-storage-creds branch from 730fd73 to ff8583c Compare September 13, 2024 12:30
@skjnldsv
Copy link
Member Author

/compile rebase /

@skjnldsv skjnldsv enabled auto-merge September 13, 2024 14:27
skjnldsv and others added 2 commits September 13, 2024 14:32
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/external-storage-creds branch from ff8583c to 233d307 Compare September 13, 2024 14:33
@skjnldsv skjnldsv merged commit 032f17c into master Sep 13, 2024
176 checks passed
@skjnldsv skjnldsv deleted the fix/external-storage-creds branch September 13, 2024 14:57
@skjnldsv
Copy link
Member Author

/backport to stable30

@skjnldsv
Copy link
Member Author

/backport to stable29

@skjnldsv
Copy link
Member Author

/backport to stable28

@skjnldsv
Copy link
Member Author

/backport 0f519f4 to stable30

@skjnldsv
Copy link
Member Author

/backport 0f519f4 to stable29

@skjnldsv
Copy link
Member Author

/backport 0f519f4 to stable28

Copy link

backportbot bot commented Sep 13, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/47945/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0f519f4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47945/stable30

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/47945/stable30."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Sep 13, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/47945/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0f519f4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47945/stable29

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/47945/stable29."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Sep 13, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/47945/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0f519f4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47945/stable30

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/47945/stable30."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Sep 13, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/47945/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0f519f4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47945/stable28

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/47945/stable28."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Enter missing credentials for external storage
4 participants