Add a migration step to save the data from the accounts table before …

[nickvergessen]

…migrating

• Copy data
• Make sure you can upgrade from 10.0.0
• Copy avatars to new location
• Recreate accounts table with our data

Signed-off-by: Joas Schilling coding@schilljs.com

[mention-bot]

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @rullzer and @MorrisJobke to be potential reviewers.

[codecov]

Codecov Report

Merging #4813 into master will decrease coverage by 0.06%.
The diff coverage is 2.67%.

@@             Coverage Diff              @@
##             master    #4813      +/-   ##
============================================
- Coverage     54.12%   54.05%   -0.07%     
- Complexity    22206    22234      +28     
============================================
  Files          1367     1368       +1     
  Lines         84983    85061      +78     
  Branches       1322     1322              
============================================
- Hits          45998    45981      -17     
- Misses        38985    39080      +95

Impacted Files	Coverage Δ	Complexity Δ
.../private/Repair/Owncloud/SaveAccountsTableData.php	0% <0%> (ø)	20 <20> (?)
...b/private/Repair/NC11/MoveAvatarsBackgroundJob.php	0% <0%> (ø)	21 <11> (+9)	⬆️
version.php	0% <0%> (ø)	0 <0> (ø)	⬇️
lib/private/Repair.php	28.2% <0%> (-0.75%)	19 <0> (ø)
lib/private/Updater.php	6.2% <23.07%> (+0.42%)	77 <0> (+4)	⬆️
apps/comments/lib/EventHandler.php	79.16% <0%> (-8.34%)	7% <0%> (ø)
apps/theming/lib/Capabilities.php	71.42% <0%> (-6.35%)	2% <0%> (-1%)
lib/private/Files/Cache/Propagator.php	94.93% <0%> (-1.27%)	16% <0%> (ø)
lib/private/Security/CertificateManager.php	90.81% <0%> (-1.03%)	39% <0%> (ø)
core/js/js.js	61.21% <0%> (-0.57%)	0% <0%> (ø)
... and 7 more

[MorrisJobke]

I get this when running an update from OC 10 to NC master:

Failed to update database structure (Doctrine\\DBAL\\Schema\\SchemaException: There is no column with name 'uid' on table 'oc_accounts'. in 3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Schema/SchemaException.php:86\nStack trace:
    #0 3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Schema/Table.php(671): Doctrine\\DBAL\\Schema\\SchemaException::columnDoesNotExist('uid', 'oc_accounts')
    #1 3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Platforms/MySqlPlatform.php(702): Doctrine\\DBAL\\Schema\\Table->getColumn('uid')
    #2 3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Platforms/MySqlPlatform.php(630): Doctrine\\DBAL\\Platforms\\MySqlPlatform->getPreAlterTableAlterPrimaryKeySQL(Object(Doctrine\\DBAL\\Schema\\TableDiff), Object(Doctrine\\DBAL\\Schema\\Index))
    #3 3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Platforms/MySqlPlatform.php(612): Doctrine\\DBAL\\Platforms\\MySqlPlatform->getPreAlterTableIndexForeignKeySQL(Object(Doctrine\\DBAL\\Schema\\TableDiff))
    #4 3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Schema/SchemaDiff.php(199): Doctrine\\DBAL\\Platforms\\MySqlPlatform->getAlterTableSQL(Object(Doctrine\\DBAL\\Schema\\TableDiff))
    #5 3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Schema/SchemaDiff.php(136): Doctrine\\DBAL\\Schema\\SchemaDiff->_toSql(Object(Doctrine\\DBAL\\Platforms\\MySQL57Platform), false)
    #6 lib/private/DB/Migrator.php(254): Doctrine\\DBAL\\Schema\\SchemaDiff->toSql(Object(Doctrine\\DBAL\\Platforms\\MySQL57Platform))
    #7 lib/private/DB/Migrator.php(86): OC\\DB\\Migrator->applySchema(Object(Doctrine\\DBAL\\Schema\\Schema))
    #8 lib/private/DB/MDB2SchemaManager.php(122): OC\\DB\\Migrator->migrate(Object(Doctrine\\DBAL\\Schema\\Schema))
    #9 lib/private/legacy/db.php(186): OC\\DB\\MDB2SchemaManager->updateDbFromStructure('/srv/projects/s...')
    #10 lib/private/Updater.php(288): OC_DB::updateDbFromStructure('/srv/projects/s...')
    #11 lib/private/Updater.php(237): OC\\Updater->doCoreUpgrade()
    #12 lib/private/Updater.php(130): OC\\Updater->doUpgrade('12.0.0.20', '10.0.0.12')
    #13 core/ajax/update.php(197): OC\\Updater->upgrade()
    #14 {main})

Any idea why it fails with this error, because it properly detects that this needs to be added.

[nickvergessen]

Grml, Maria DB? I think we need to kill the table completly because it tries to update the primary index instead of deleting + recreating. But that doesn't work, because it still contains wrong columns after adding and before removing of the old columns

[MorrisJobke]

Grml, Maria DB?

No - MySQL 5.7.18 on Ubuntu 16.04

[nickvergessen]

Fixed, also adjusted the background job that copies the avatars to work with ownclouds new location.

[nickvergessen]

@schiessle please help with generating the account table entries

[rullzer]

Makes sense. 👍 Avatars got moved for me

[nickvergessen]

So aparently the account entries are created on next usage then. So should be fine.

[nickvergessen]

Rebased for version.php change