fix(caldav): explicitly check from component types #48131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
requested review from
ChristophWurst and
tcitworld
as code owners
miaulalala
requested review from
a team,
Altahrim,
skjnldsv,
st3iny,
tcitworld and
yemkareems
and removed request for
a team,
ChristophWurst and
tcitworld
miaulalala
added
3. to review
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
ChristophWurst
approved these changes
Sep 17, 2024
miaulalala
force-pushed
the
fix/filter-for-components-explicitly
branch
from
b90e8f0 to
a65cf51
Compare
Member
|
Could you make the PR description a bit more verbose? |
Member
|
/backport to stable31 |
AndyScherzinger
force-pushed
the
fix/filter-for-components-explicitly
branch
from
a65cf51 to
cd306b8
Compare
SebastianKrupinski
force-pushed
the
fix/filter-for-components-explicitly
branch
from
a8b4ff6 to
548131b
Compare
auto-merge was automatically disabled
May 9, 2025 16:08
Pull request was converted to draft
SebastianKrupinski
force-pushed
the
fix/filter-for-components-explicitly
branch
3 times, most recently
from
5716382 to
79c9ed4
Compare
SebastianKrupinski
removed request for
Altahrim,
skjnldsv,
tcitworld and
yemkareems
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
SebastianKrupinski
force-pushed
the
fix/filter-for-components-explicitly
branch
from
79c9ed4 to
8f4c562
Compare
SebastianKrupinski
force-pushed
the
fix/filter-for-components-explicitly
branch
from
8f4c562 to
06fbea0
Compare
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
fix/filter-for-components-explicitly
branch
from
06fbea0 to
64377b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ignore everything but the specific component types that are defined as valid in the RFC. We should only denormalize data that is actually valid, and skip any invalid data structures. Otherwise we run into the danger of returning trash data.
TODO
Checklist