Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide checkbox in avatarcropper #4826

Merged
merged 1 commit into from
May 12, 2017
Merged

Hide checkbox in avatarcropper #4826

merged 1 commit into from
May 12, 2017

Conversation

MorrisJobke
Copy link
Member

bildschirmfoto_2017-05-11_um_19_18_44

@MorrisJobke
Hide checkbox in avatarcropper
f444090 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix. labels May 12, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone May 12, 2017
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @jancborchardt and @ChristophWurst to be potential reviewers.

@nickvergessen nickvergessen mentioned this pull request May 12, 2017
Closed
59 tasks
@MorrisJobke
Copy link
Member Author

Fixes an papercut item from #2672

@codecov
Copy link

codecov bot commented May 12, 2017 •
edited
Loading

Codecov Report

Merging #4826 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4826      +/-   ##
============================================
+ Coverage     54.19%   54.19%   +<.01%     
  Complexity    22149    22149              
============================================
  Files          1363     1363              
  Lines         84820    84820              
  Branches       1322     1322              
============================================
+ Hits          45966    45970       +4     
+ Misses        38854    38850       -4
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
core/js/js.js 61.78% <0%> (+0.56%) 0% <0%> (ø) ⬇️

@nickvergessen nickvergessen merged commit 16d8481 into master May 12, 2017
@nickvergessen nickvergessen deleted the hide-cropper-input branch May 12, 2017 07:54
@asheroto asheroto mentioned this pull request Sep 19, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@MariusBluem MariusBluem Awaiting requested review from MariusBluem

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MorrisJobke @mention-bot @rullzer @nickvergessen