Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix(Auth): ignore missing token when trying to set password-unconfirmable #48445

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[stable28] fix(Auth): ignore missing token when trying to set password-unconfirmable #48445

merged 1 commit into from
Oct 1, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Sep 30, 2024 •
edited
Loading

Summary

When the token is unavailable an Excpetion may kill the running request.

Checklist

@blizzz
fix(Auth): ignore missing token when trying to set password-unconfirm…
4dd1f38 
…able

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added the 3. to review Waiting for reviews label Sep 30, 2024
@blizzz blizzz added this to the Nextcloud 28.0.11 milestone Sep 30, 2024
@blizzz blizzz changed the title fix(Auth): ignore missing token when trying to set password-unconfirmable [stable28] fix(Auth): ignore missing token when trying to set password-unconfirmable Sep 30, 2024
julien-nc
julien-nc approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though I have no clue how these exceptions are dealt with somewhere else.

@blizzz blizzz marked this pull request as ready for review October 1, 2024 10:16
@blizzz
Copy link
Member Author

blizzz commented Oct 1, 2024 •
edited
Loading

Looks good though I have no clue how these exceptions are dealt with somewhere else.

OC\User\Session is dealing with them.

@blizzz blizzz mentioned this pull request Oct 1, 2024
Merged
@blizzz
Copy link
Member Author

blizzz commented Oct 1, 2024

/backport to stable27

@blizzz blizzz merged commit e3cce26 into stable28 Oct 1, 2024
59 checks passed
@blizzz blizzz deleted the fix/noid/ignore-unavailable-token branch October 1, 2024 13:57
@backportbot backportbot bot mentioned this pull request Oct 1, 2024
Merged
@Altahrim Altahrim mentioned this pull request Oct 1, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@julien-nc julien-nc julien-nc approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28.0.11
Development

Successfully merging this pull request may close these issues.
3 participants
@blizzz @kesselb @julien-nc