-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(migration): Check if column exits before adding it #48480
Conversation
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
/backport to stable30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! Can we somehow add a test for this so that such an if clause is never forgotten?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check makes sense, but I don't understand the state people are ending up in in that bug report: upgrading from v29 directly shouldn't have that column anyhow.
Integration testing focused on the the upgrade path should catch these (which we don't have AFAIK). Particularly if we had a matrix covering major->major, beta->major, rc->major, etc. |
Yet this is out of the scope of this specific PR, I fully agree on this. |
Checklist