Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use insert ignore for filecache_extended #48564

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use insert ignore for filecache_extended #48564

wants to merge 1 commit into from
+6 −12

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 3, 2024 •
edited
Loading

Summary

TODO

  • [ ]

Checklist

@kesselb kesselb added enhancement 2. developing Work in progress labels Oct 3, 2024
@kesselb kesselb added this to the Nextcloud 31 milestone Oct 3, 2024
@kesselb kesselb self-assigned this Oct 3, 2024
@kesselb
fix: use insert ignore for filecache_extended
af89838 
The current approach is to insert a new row and, if a unique constraint violation occurs, update an existing one. PostgreSQL logs the unique constraint violation as error "duplicate key value violates unique constraint".

Our Adapter.insertIgnoreConflict method provides a way to run an insert query without logging such errors by using the vendor-specific sql extensions like "on conflict do nothing" on Postgres.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the bug/19494/insert-ignore-conflict-for-filecache-extended branch from cda4948 to af89838 Compare October 7, 2024 11:30
@kesselb kesselb changed the title wip fix: use insert ignore for filecache_extended Oct 7, 2024
@kesselb kesselb mentioned this pull request Oct 7, 2024
Open
nickvergessen
nickvergessen approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least seems to solve the issue on 29 (without sharding)

@nickvergessen
Copy link
Member

@kesselb any chance to continue/finalize this?

@ShGKme
Copy link
Contributor

ShGKme commented Oct 25, 2024

I guess, sharding support is a blocking problem?

@kesselb
Copy link
Contributor Author

kesselb commented Oct 25, 2024

I guess, sharding support is a blocking problem?

Yep, I wrote down my findings at #19494 (comment) and handed the ticket over to Stephan.

@nickvergessen
Copy link
Member

The fix could applied on the older versions never the less?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@kesselb kesselb

Labels
2. developing Work in progress enhancement
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

PostgreSQL duplicate key value violates unique constraint
3 participants
@kesselb @nickvergessen @ShGKme