Fix email share transfer accross storages #48597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes debbuging way easier Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
This fixes transfering an email share from a user to another one when using objectstore as primary storage. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
susnux
requested review from
a team,
icewind1991,
Altahrim and
provokateurin
and removed request for
a team
susnux
reviewed
Oct 7, 2024
| @@ -739,11 +739,14 @@ public function update(IShare $share, ?string $plainTextPassword = null): IShare | |||
| $shareAttributes = $this->formatShareAttributes($share->getAttributes()); | |||
|
|
|||
| /* | |||
| * We allow updating the permissions and password of mail shares | |||
| * We allow updating mail shares | |||
There was a problem hiding this comment.
IMHO Things like this should not be checked in "mappers" but only in the controllers.
susnux
approved these changes
Oct 7, 2024
provokateurin
approved these changes
Oct 7, 2024
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up of #44904 to fix email shares.
Checklist