Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix(settings): Use axios directly for health check to preven URL sanitizing #48615

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 8, 2024

Backport of #45765

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

…tizing

When using Apache with `DirectorySlash` it will respond with 301 and the URL with trailing slash.
But when using traefik as the reverse proxy it can not rewrite redirects, this leads to the problem
that the Apache response is using HTTP in the redirect but the real server (traefik) is only listening on HTTPS.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@backportbot backportbot bot added the 3. to review Waiting for reviews label Oct 8, 2024
@backportbot backportbot bot added this to the Nextcloud 30.0.1 milestone Oct 8, 2024
@susnux
Copy link
Contributor

susnux commented Oct 8, 2024

/compile amend/

@susnux susnux marked this pull request as ready for review October 8, 2024 13:53
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger merged commit 3b51990 into stable30 Oct 8, 2024
112 of 113 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/45765/stable30 branch October 8, 2024 15:08
This was referenced Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants