-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(locking): Accept mixed as value on setTTL #48689
Conversation
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
/backport to stable30 |
/backport to stable29 |
/backport to stable28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
I've spotted that error some days ago in a log.
The fix looks okay to me, but I'm not familiar enough with the locking code to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably copy-pasta from the ttl parameter 👍
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/48689/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8f7784bd
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48689/stable28 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
Fix:
Underlying
compareSetTTL
also accepts mixed values.Checklist