Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix: Shipped apps should include the Nextcloud version in the cache buster #48700

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 14, 2024

Manual backport of #48650

@susnux susnux added bug 3. to review Waiting for reviews labels Oct 14, 2024
@susnux susnux added this to the Nextcloud 29.0.9 milestone Oct 14, 2024
@Altahrim Altahrim mentioned this pull request Oct 30, 2024
4 tasks
@Altahrim
Copy link
Collaborator

CI error sounds related

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, @susnux please take a look

@susnux
Copy link
Contributor Author

susnux commented Oct 30, 2024

CI error sounds related

Yes but it is super weird, not happening on master and can not reproduce locally... Will see.

…uster

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/cachebuster-stable30 branch from 42aa766 to 9500984 Compare October 30, 2024 09:29
@susnux susnux requested a review from provokateurin October 30, 2024 09:29
@susnux
Copy link
Contributor Author

susnux commented Oct 30, 2024

✍️ todo for later: Move everything from that horrible constructor to the render function or similar.
Due to that we can not even mock that class (partially) because everything is already accessed in the constructor before you can configure the methods...

@susnux susnux merged commit df946f4 into stable29 Oct 30, 2024
181 checks passed
@susnux susnux deleted the fix/cachebuster-stable30 branch October 30, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants