Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate from deprecated SASS API and SASS JS API #48702

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 14, 2024

Summary

Upgrade sass-loader from 13 to 16. It also requires upgrading @nextcloud/webpack-vue-config and style-loader with css-loader. This removes hundreds warnings about using deprecated SASS JS API.
image

Migrate from deprecated SASS API.
See: https://sass-lang.com/documentation/modules/color/
image

See: https://sass-lang.com/documentation/breaking-changes/mixed-decls/
image

Checklist

…loaders

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added 3. to review Waiting for reviews technical debt labels Oct 14, 2024
@ShGKme ShGKme added this to the Nextcloud 31 milestone Oct 14, 2024
@ShGKme ShGKme requested review from susnux and skjnldsv October 14, 2024 16:40
@ShGKme ShGKme marked this pull request as draft October 14, 2024 16:41
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the chore/update-sass-loader branch from c1e8851 to 39ebc6e Compare October 14, 2024 16:54
@ShGKme ShGKme marked this pull request as ready for review October 14, 2024 16:55
@susnux
Copy link
Contributor

susnux commented Oct 15, 2024

👀

image

@susnux susnux enabled auto-merge October 15, 2024 11:56
@susnux susnux merged commit a5d8f4c into master Oct 15, 2024
120 of 122 checks passed
@susnux susnux deleted the chore/update-sass-loader branch October 15, 2024 13:11
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants