Skip to content

Conversation

@Bestora
Copy link

@Bestora Bestora commented Oct 18, 2024

Summary

The custom markdown renderer heading for "marked" used fn(text,level).

In the docs it's this:
https://marked.js.org/using_pro
heading({ tokens, depth }: Tokens.Heading): string;

interface Heading {
	type: "heading";
	raw: string;
	depth: number;
	text: string;
	tokens: Token[];
}

Before:
image

After:
image

TODO

Checklist

The custom renderer for heading on "marked" used fn(text,level). The documentation of marked gives a object of type "Heading"

	interface Heading {
		type: "heading";
		raw: string;
		depth: number;
		text: string;
		tokens: Token[];
	}

Signed-off-by: Dennis Rehbehn <dennisrehbehn@googlemail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link

@am-hachim am-hachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the content of your branch, and the changes have been made.

@susnux susnux added this to the Nextcloud 32 milestone Mar 2, 2025
This was referenced Aug 22, 2025
This was referenced Sep 2, 2025
This was referenced Sep 25, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [object Object] show in place of headings on 'Your apps' page, app details panel, description tab

4 participants