Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_sharing): Cleanup error messages #48918

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Oct 28, 2024

Summary

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Oct 28, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Oct 28, 2024
@provokateurin provokateurin requested review from artonge, skjnldsv, a team and sorbaugh and removed request for a team October 28, 2024 07:08
@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@provokateurin
Copy link
Member Author

/backport to stable28

Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some of the messages can be more specific? For example the try-catch that fails due to date parsing and only that can be a bit more explicit at maybe the expense of consistency with the same "Failed to..."

@provokateurin provokateurin force-pushed the fix/files_sharing/cleanup-error-messages branch from 64fd4eb to 53ddaa3 Compare October 28, 2024 07:55
@provokateurin
Copy link
Member Author

Maybe some of the messages can be more specific? For example the try-catch that fails due to date parsing and only that can be a bit more explicit at maybe the expense of consistency with the same "Failed to..."

Fixed. The called method was already returning a proper error message, so I aligned all the uses of it.

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the fix/files_sharing/cleanup-error-messages branch from 53ddaa3 to aacb3dd Compare October 28, 2024 08:07
@provokateurin provokateurin merged commit 8b5e1ba into master Oct 28, 2024
177 checks passed
@provokateurin provokateurin deleted the fix/files_sharing/cleanup-error-messages branch October 28, 2024 11:47
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants