-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files_sharing): Cleanup error messages #48918
fix(files_sharing): Cleanup error messages #48918
Conversation
/backport to stable30 |
/backport to stable29 |
/backport to stable28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe some of the messages can be more specific? For example the try-catch that fails due to date parsing and only that can be a bit more explicit at maybe the expense of consistency with the same "Failed to..."
64fd4eb
to
53ddaa3
Compare
Fixed. The called method was already returning a proper error message, so I aligned all the uses of it. |
Signed-off-by: provokateurin <kate@provokateurin.de>
53ddaa3
to
aacb3dd
Compare
Summary
Checklist