Implement ownerless shares #49073
Implement ownerless shares #49073
Conversation
| $shares = []; | ||
| foreach ($providers as $provider) { | ||
| if ($isCoOwner) { | ||
| foreach ($node->getDirectoryListing() as $childNode) { |
There was a problem hiding this comment.
This makes it a lot more expensive, can we tweak getSharesInFolder to make the $user filter optional instead?
There was a problem hiding this comment.
We can't do this without a breaking change, as it would break provider implementations that don't expect to receive null.
Maybe that is fine though, as long as the providers only do database SELECTs where a null value is fine (but that would still result in unexpected results as nothing would be returned instead of everything).
There was a problem hiding this comment.
Istead of null it could receive a keyword.
provokateurin
force-pushed
the
feat/files_sharing/co-owner
branch
from
dbee0fb to
0ee7f19
Compare
provokateurin
requested review from
a team,
ArtificialOwl,
icewind1991 and
come-nc
and removed request for
a team
|
Added tests for everything 🎉 |
provokateurin
added
3. to review
provokateurin
force-pushed
the
feat/files_sharing/co-owner
branch
3 times, most recently
from
4c63eba to
cd4dc54
Compare
|
maybe |
|
Sure I will go with that, even though it is still inaccurate :/ |
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
feat/files_sharing/co-owner
branch
from
cd4dc54 to
5ec57e4
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
…ath() Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
…es on IShareOwnerlessMount Signed-off-by: provokateurin <kate@provokateurin.de>
…hare Signed-off-by: provokateurin <kate@provokateurin.de>
… owner Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
feat/files_sharing/co-owner
branch
from
5ec57e4 to
c0db746
Compare
| * | ||
| * @since 31.0.0 | ||
| */ | ||
| interface IShareOwnerlessMount { |
There was a problem hiding this comment.
| interface IShareOwnerlessMount { | |
| interface IShareOpenMount { | |
| // interface IShareCollaborativeMount |
Might be too far and too large a refactor at this point but just throwing in the idea.
There was a problem hiding this comment.
Hm IShareCollaborativeMount doesn't sound too bad. @ArtificialOwl what do you think?
There was a problem hiding this comment.
I also already did a rename of everything this morning, so doing it once more is not much work 🙈
provokateurin
added
the
pending documentation
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
provokateurin
removed
the
pending documentation
|
Will this enhancement reach the expected behavior asked in |
Summary
Can be tested with nextcloud/groupfolders#3401
Tests still need to be written, but other than that this is ready.It doesn't work with files_external yet, but I think that is due to permissions (UI says there is no reshare permission).
I'm surprised how little lines had to be changed in the end, but the challenging part was exploring how this can be implemented and where things needs to be changed and fixed to make it work.
Behavior:
deletedhiddenChecklist