Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Middleware): log deprecation when annotation was actually used #49237

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Nov 12, 2024

fixes debug messages about the usage of an annotation like '@CORS` where it actually is not used.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added bug 3. to review Waiting for reviews labels Nov 12, 2024
@blizzz blizzz added this to the Nextcloud 31 milestone Nov 12, 2024
@blizzz blizzz requested review from nickvergessen, provokateurin, a team, skjnldsv and sorbaugh and removed request for a team November 12, 2024 21:17
@blizzz
Copy link
Member Author

blizzz commented Nov 12, 2024

/backport to stable30

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably didn't look to closely when copying it, on the other two checks it is in the correct place 😅

@provokateurin provokateurin merged commit a489d88 into master Nov 13, 2024
186 checks passed
@provokateurin provokateurin deleted the fix/noid/deprecation-correct-case branch November 13, 2024 06:28
@blizzz
Copy link
Member Author

blizzz commented Nov 13, 2024

I probably didn't look to closely when copying it, on the other two checks it is in the correct place 😅

Relieved to hear it is not only me struggling with Copy 'n'Paste Tactics 😁

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants