Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Make injected actions reactive #49271

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 14, 2024

Summary

Provided values are not reactive by default and by design, we must need computed to make them reactive.

Checklist

@susnux susnux added this to the Nextcloud 31 milestone Nov 14, 2024
@susnux susnux requested review from a team and nfebe and removed request for a team November 14, 2024 00:04
@susnux susnux requested a review from skjnldsv as a code owner November 14, 2024 00:04
@susnux susnux requested review from skjnldsv and sorbaugh November 14, 2024 00:04
@susnux
Copy link
Contributor Author

susnux commented Nov 14, 2024

/backport to stable30

@susnux susnux self-assigned this Nov 14, 2024
@susnux susnux requested a review from Pytal November 14, 2024 00:04
Provided values are not reactive by default and by design,
we must need computed to make them reactive.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/files/reactivity-inject branch from f09812e to b1df25a Compare November 15, 2024 11:17
@susnux
Copy link
Contributor Author

susnux commented Nov 15, 2024

/compile

@susnux susnux enabled auto-merge November 15, 2024 11:17
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit d1e9267 into master Nov 15, 2024
118 checks passed
@susnux susnux deleted the fix/files/reactivity-inject branch November 15, 2024 11:33
@susnux
Copy link
Contributor Author

susnux commented Nov 21, 2024

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files context menu options changes after navigation to the groupfolder and back
4 participants