Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(files): Replace deprecated Types enum for share types #49300

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 15, 2024

Summary

Replace with ShareType enum.
Also fix some small Typescript issues in FilesList.vue.

Checklist

@susnux susnux added 3. to review Waiting for reviews feature: files technical debt ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Nov 15, 2024
@susnux susnux added this to the Nextcloud 31 milestone Nov 15, 2024
@susnux susnux requested a review from a team November 15, 2024 01:34
@susnux susnux requested a review from skjnldsv as a code owner November 15, 2024 01:34
@susnux susnux requested review from nfebe, skjnldsv and sorbaugh and removed request for a team November 15, 2024 01:34
Replace with `ShareType` enum.
Also fix some small Typescript issues in `FilesList.vue`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the refactor/files-deprecated-share-types branch from 03f0714 to 7e55c87 Compare November 18, 2024 11:27
@susnux susnux enabled auto-merge November 18, 2024 11:27
@susnux susnux merged commit c74ba56 into master Nov 18, 2024
118 checks passed
@susnux susnux deleted the refactor/files-deprecated-share-types branch November 18, 2024 11:40
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants