Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enforce running stylelint #49342

Merged
merged 4 commits into from
Nov 19, 2024
Merged

ci: Enforce running stylelint #49342

merged 4 commits into from
Nov 19, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 18, 2024

Summary

We have a stylelint config, but we do not enforce it.
So this adds the CI workflow and fixes all errors and warning we currently have 🙈

TODO

Checklist

@susnux susnux added 3. to review Waiting for reviews CI ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Nov 18, 2024
@susnux susnux added this to the Nextcloud 31 milestone Nov 18, 2024
@susnux susnux force-pushed the chore/force-style-lint branch from 5aa503d to 3d83b6c Compare November 18, 2024 11:34
@susnux susnux marked this pull request as ready for review November 18, 2024 14:04
@susnux susnux requested a review from skjnldsv as a code owner November 18, 2024 14:04
@susnux susnux force-pushed the chore/force-style-lint branch from 3d83b6c to 7737ac4 Compare November 18, 2024 14:04
@susnux susnux requested review from a team, artonge and nfebe and removed request for a team November 18, 2024 14:04
@skjnldsv
Copy link
Member

Eslint not happy too

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…elint config

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv force-pushed the chore/force-style-lint branch from 7737ac4 to be33943 Compare November 19, 2024 08:43
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 19, 2024
@skjnldsv skjnldsv enabled auto-merge November 19, 2024 08:43
@skjnldsv skjnldsv mentioned this pull request Nov 19, 2024
4 tasks
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the chore/force-style-lint branch from be33943 to dd5a344 Compare November 19, 2024 08:56
@skjnldsv skjnldsv merged commit fb75e2d into master Nov 19, 2024
190 checks passed
@skjnldsv skjnldsv deleted the chore/force-style-lint branch November 19, 2024 09:14
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish CI ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants