-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Enforce running stylelint #49342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
Waiting for reviews
CI
♻️ refactor
Refactor code (not a bug fix, not a feature just refactoring)
labels
Nov 18, 2024
susnux
force-pushed
the
chore/force-style-lint
branch
from
November 18, 2024 11:34
5aa503d
to
3d83b6c
Compare
susnux
force-pushed
the
chore/force-style-lint
branch
from
November 18, 2024 14:04
3d83b6c
to
7737ac4
Compare
susnux
requested review from
a team,
artonge and
nfebe
and removed request for
a team
November 18, 2024 14:04
artonge
approved these changes
Nov 18, 2024
Eslint not happy too |
skjnldsv
approved these changes
Nov 19, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…elint config Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
skjnldsv
force-pushed
the
chore/force-style-lint
branch
from
November 19, 2024 08:43
7737ac4
to
be33943
Compare
skjnldsv
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Nov 19, 2024
4 tasks
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
chore/force-style-lint
branch
from
November 19, 2024 08:56
be33943
to
dd5a344
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
CI
♻️ refactor
Refactor code (not a bug fix, not a feature just refactoring)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have a stylelint config, but we do not enforce it.
So this adds the CI workflow and fixes all errors and warning we currently have 🙈
TODO
Checklist