Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Two Factor API #49443

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

feat: Two Factor API #49443

wants to merge 8 commits into from
+350 −0

Conversation

SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Nov 23, 2024 •
edited
Loading

Ability to check/enable/disable configured 2FA with API endpoint

Request State

POST /twofactor/state

{
	"users": ["admin", "user1", "user2"]
}

Request Disable

POST /twofactor/disable

{
  "user": "user1",
  "providers": [
    "backup_codes",
    "totp"
  ]
}

Request Enable

POST /twofactor/enable

{
  "user": "user2",
  "providers": [
    "backup_codes",
    "totp"
  ]
}

@SebastianKrupinski
feat: Two Factor API
36674f5 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski added the 2. developing Work in progress label Nov 23, 2024
@SebastianKrupinski SebastianKrupinski self-assigned this Nov 23, 2024
@SebastianKrupinski SebastianKrupinski marked this pull request as draft November 23, 2024 00:12
SebastianKrupinski and others added 4 commits November 28, 2024 20:42
@SebastianKrupinski
fixup! feat: Two Factor API
5b255be 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
fixup! feat: Two Factor API
e13f498 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
fixup! feat: Two Factor API
207f5cd 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
Merge branch 'master' into feat/issue-994-two-factor-api
78e280f
@SebastianKrupinski
fixup! fixup! feat: Two Factor API
643480f 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
fixup! fixup! feat: Two Factor API
d65b567 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
fixup! fixup! feat: Two Factor API
048dbcb 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
nickvergessen
nickvergessen requested changes Dec 15, 2024
View reviewed changes
core/Controller/TwoFactorApiController.php
* 200: provider states
* 404: user not found
*/
#[PublicPage]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[PublicPage]

core/Controller/TwoFactorApiController.php
* 200: provider states
* 404: user not found
*/
#[PublicPage]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[PublicPage]

core/Controller/TwoFactorApiController.php
*
* 200: user/provider states
*/
#[PublicPage]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[PublicPage]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen requested changes

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin will be requested when the pull request is marked ready for review provokateurin is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@SebastianKrupinski SebastianKrupinski

Labels
2. developing Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SebastianKrupinski @nickvergessen