Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore vendor-bin for coverage #49833

Merged
merged 2 commits into from
Dec 17, 2024
Merged

chore: ignore vendor-bin for coverage #49833

merged 2 commits into from
Dec 17, 2024

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Dec 12, 2024

Summary

  • Otherwise the coverage for *.php files in vendor-bin is also calculated.
  • Fix Error: The "--coverage-clover" option does not exist. for the external generic workflow.

Checklist

@kesselb kesselb added the 3. to review Waiting for reviews label Dec 12, 2024
@kesselb kesselb added this to the Nextcloud 31 milestone Dec 12, 2024
@kesselb kesselb self-assigned this Dec 12, 2024
@kesselb kesselb force-pushed the chore/noid/coverage branch from a57b9fe to 4b856a7 Compare December 13, 2024 11:15
@@ -74,7 +74,7 @@ jobs:
./occ app:enable --force files_external

- name: PHPUnit
run: composer run test:files_external \
run: composer run test:files_external -- \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@kesselb kesselb force-pushed the chore/noid/coverage branch from 4b856a7 to bd09590 Compare December 15, 2024 15:57
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does one see the coverage data?

@kesselb
Copy link
Contributor Author

kesselb commented Dec 16, 2024

It's uploaded to: https://app.codecov.io/gh/nextcloud/server

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the chore/noid/coverage branch from bd09590 to 11a2be4 Compare December 16, 2024 14:47
@kesselb kesselb merged commit fe90aa3 into master Dec 17, 2024
191 checks passed
@kesselb kesselb deleted the chore/noid/coverage branch December 17, 2024 15:20
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants