fix: Properly read updater channel before returning version channel as a fallback #50368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
added
bug
31-feedback
1. to develop
|
/backport to stable31 |
|
The channel property should be dropped then |
provokateurin
approved these changes
Jan 23, 2025
nickvergessen
approved these changes
Jan 23, 2025
skjnldsv
approved these changes
Jan 23, 2025
juliusknorr
force-pushed
the
fix/version-channel
branch
from
fad898b to
a47efd1
Compare
Yep, probably do not need this in versions.php anymore, but something for another day |
But that's how enterprise vs. stable is automatically set? |
I overlooked the default usage, so that's fine. |
…s a fallback Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorr
force-pushed
the
fix/version-channel
branch
from
a47efd1 to
caf074e
Compare
juliusknorr
added
3. to review
Altahrim
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julius Knorr jus@bitgrid.net
Summary
While doing the upgrade to rc1 we noticed that the app store fetching did not return apps for the 31 release. This is due to a regression from 606241c and hasn't shown during beta as the release script will use a different channel for beta releases
Checklist