Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use redundant label for accesibility only #50399

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Jan 24, 2025

Use redundant label for accessibility only

Screenshots

Before After
Screenshot from 2025-01-24 13-21-46 Screenshot from 2025-01-24 13-33-08

@nfebe nfebe force-pushed the ehn/sharing-sidebar-hide-search-labels branch from 62cad22 to c92cf5a Compare January 24, 2025 12:40
@nfebe
Copy link
Contributor Author

nfebe commented Jan 24, 2025

/compile

@nfebe nfebe requested a review from marcoambrosini January 24, 2025 12:41
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a class for that

@nfebe nfebe force-pushed the ehn/sharing-sidebar-hide-search-labels branch from 98c29d4 to 0e69b7e Compare January 24, 2025 13:26
@nfebe nfebe requested a review from susnux January 24, 2025 13:29
@nfebe
Copy link
Contributor Author

nfebe commented Jan 24, 2025

/compile

@AndyScherzinger
Copy link
Member

/backport to stable31

@AndyScherzinger AndyScherzinger force-pushed the ehn/sharing-sidebar-hide-search-labels branch from c31c20e to 4838b69 Compare January 25, 2025 07:57
@nfebe
Copy link
Contributor Author

nfebe commented Jan 25, 2025

Hello @AndyScherzinger Please review and approve to trigger backport.

nfebe and others added 2 commits January 25, 2025 12:04
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger force-pushed the ehn/sharing-sidebar-hide-search-labels branch from 4838b69 to aff0f25 Compare January 25, 2025 11:04
@nfebe nfebe merged commit 09a50d4 into master Jan 25, 2025
120 checks passed
@nfebe nfebe deleted the ehn/sharing-sidebar-hide-search-labels branch January 25, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

4 participants