Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

files: harden thumbnail endpoint #50430

Merged
merged 2 commits into from
Jan 26, 2025
Merged

files: harden thumbnail endpoint #50430

merged 2 commits into from
Jan 26, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 25, 2025 •
edited
Loading

Summary

Checklist

@susnux susnux added this to the Nextcloud 32 milestone Jan 25, 2025
@susnux
fix(files): Harden thumbnail endpoint
08319ad 
- Catch all thrown exceptions and handle in such a way you do not get
  information about forbidden files.
- Resepect download permissions of shares.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/harden-thumbnail-endpoint branch from be2dace to 1608e7c Compare January 26, 2025 14:21
@susnux
chore(files): Deprecate thumbnail endpoint in favor of core preview e…
3c357f8 
…ndpoint

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/harden-thumbnail-endpoint branch from 1608e7c to 3c357f8 Compare January 26, 2025 14:25
@susnux
Copy link
Contributor Author

susnux commented Jan 26, 2025

/backport 08319ad to stable31

@susnux
Copy link
Contributor Author

susnux commented Jan 26, 2025

/backport 08319ad to stable30

@susnux susnux mentioned this pull request Jan 26, 2025
Merged
@AndyScherzinger AndyScherzinger merged commit 8981f32 into master Jan 26, 2025
189 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/harden-thumbnail-endpoint branch January 26, 2025 15:18
This was referenced Jan 26, 2025
Merged
Merged
@susnux
Copy link
Contributor Author

susnux commented Jan 26, 2025

/backport to stable29

@backportbot backportbot bot mentioned this pull request Jan 26, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@provokateurin provokateurin provokateurin approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@come-nc come-nc Awaiting requested review from come-nc

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: files
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @AndyScherzinger @provokateurin