Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exclude non accepted shares when computing access list #50519

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jan 29, 2025

No description provided.

@artonge artonge self-assigned this Jan 29, 2025
@artonge
Copy link
Contributor Author

artonge commented Jan 29, 2025

/backport to stable31

@artonge
Copy link
Contributor Author

artonge commented Jan 29, 2025

/backport to stable30

@artonge
Copy link
Contributor Author

artonge commented Jan 29, 2025

/backport to stable29

@artonge artonge added bug 3. to review Waiting for reviews php Pull requests that update Php code labels Jan 29, 2025
@artonge artonge added this to the Nextcloud 31 milestone Jan 29, 2025
@artonge artonge force-pushed the artonge/fix/access_list_unaccepted_shares branch from 1927cb6 to 7e95994 Compare January 29, 2025 09:31
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the trick 👍

The failing tests look related, and the branch is a bit behind 🤔

@blizzz blizzz mentioned this pull request Jan 29, 2025
1 task
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
@artonge artonge force-pushed the artonge/fix/access_list_unaccepted_shares branch from 7e95994 to 781bd8c Compare January 29, 2025 16:29
@artonge artonge enabled auto-merge January 29, 2025 16:58
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/access_list_unaccepted_shares branch from 781bd8c to b6c7c28 Compare January 30, 2025 08:57
@artonge artonge merged commit c89e139 into master Jan 30, 2025
190 of 191 checks passed
@artonge artonge deleted the artonge/fix/access_list_unaccepted_shares branch January 30, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants