Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ConvertType): Read dbtype in createConnectionParams and remove safeguard #50530

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Jan 29, 2025

Summary

Fixes #45257
Unforked version of #48666.
While testing I also found that #39242 read the hostname wrong which never worked.

I tested it successfully like this (make sure to have pdo_pgsql enabled):

docker run --rm --network=host --env POSTGRES_PASSWORD=postgres postgres:17
./occ maintenance:install --admin-pass admin
./occ db:convert-type --all-apps --password=postgres -- pgsql postgres localhost postgres
rm data/owncloud.db

Checklist

@provokateurin
Copy link
Member Author

/backport to stable31

@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@blizzz blizzz mentioned this pull request Jan 29, 2025
1 task
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the any auto tests for this?

@provokateurin
Copy link
Member Author

Are the any auto tests for this?

No unfortunately not, as changing the DB inside the tests is not a good idea. I still want to add a test for it later though, but will have to see in what form.

Nils Wenninghoff and others added 2 commits January 30, 2025 09:24
…feguard

Signed-off-by: Nils Wenninghoff <nils@ungemein.cool>
Signed-off-by: provokateurin <kate@provokateurin.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: occ db:convert-type broken since PrimaryReadReplicaConnection support added
5 participants