Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable30] Add LDAP test settings command #50691

Merged
merged 4 commits into from
Mar 6, 2025
Merged

[stable30] Add LDAP test settings command #50691

merged 4 commits into from
Mar 6, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 6, 2025 •
edited by max-nextcloud
Loading

@backportbot backportbot bot added this to the Nextcloud 30.0.6 milestone Feb 6, 2025
@come-nc come-nc force-pushed the backport/50567/stable30 branch from 2866be8 to ab8debb Compare February 10, 2025 16:29
@come-nc come-nc marked this pull request as ready for review February 10, 2025 16:29
@come-nc come-nc requested a review from blizzz as a code owner February 10, 2025 16:29
@come-nc
Copy link
Contributor

come-nc commented Feb 10, 2025

/backport to stable29

come-nc
come-nc requested changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment •
edited by AndyScherzinger
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a backport of #46114 first -> #50778

This was referenced Feb 11, 2025
Merged
Merged
@blizzz blizzz mentioned this pull request Mar 4, 2025
Merged
13 tasks
come-nc added 4 commits March 5, 2025 17:01
@come-nc @max-nextcloud
feat(user_ldap): upstream common code into Proxy class and add public…
bbcb102 
… getters for backends

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc @max-nextcloud
feat(user_ldap): Add command test-user-settings to test LDAP user set…
8a39411 
…tings

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc @max-nextcloud
fix(user_ldap): Remove redundant if check
779f293 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc @max-nextcloud
feat(user_ldap): Add a --clearcache option to ldap:test-user-settings
11ce100 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@max-nextcloud max-nextcloud force-pushed the backport/50567/stable30 branch from ab8debb to 11ce100 Compare March 5, 2025 16:01
max-nextcloud
max-nextcloud approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared the backport and made sure the backport this depends upon is in.

come-nc
come-nc approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works.

@max-nextcloud max-nextcloud merged commit be312b5 into stable30 Mar 6, 2025
177 checks passed
@max-nextcloud max-nextcloud deleted the backport/50567/stable30 branch March 6, 2025 11:52
@backportbot backportbot bot mentioned this pull request Mar 6, 2025
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

@kesselb kesselb Awaiting requested review from kesselb

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews enhancement feature: ldap
Projects
None yet
Milestone
Nextcloud 30.0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@come-nc @max-nextcloud @Altahrim