dont die if we try to access the shared cache while setting up the shared storage #5091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ared storage Signed-off-by: Robin Appelman <robin@icewind.nl>
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @MorrisJobke and @rullzer to be potential reviewers. |
|
Ping for review |
|
I still fail to have reproduction steps for this |
|
@nickvergessen I'm not sure about the exact reproduction steps, from what I can tell it only happens in some sharing setups. See #3110 (comment) for a backtrace that describes the problem |
|
👍 from #3110 (comment) |
nickvergessen
approved these changes
Jun 19, 2017
This was referenced Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While setting up the shared storage it tries to get the file by id, this can call
getPathByIdon the shared storage that is being setup at the moment, leading to a source storage that isn't set yet.Fixes #3110
@idmacdonald @znerol can you verify that this fixes the problem for you