Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AppDiscover): Strip double-quotes from folder name #51379

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

solracsf
Copy link
Member

Checklist

@solracsf solracsf added the 2. developing Work in progress label Mar 10, 2025
@solracsf solracsf added this to the Nextcloud 32 milestone Mar 10, 2025
@solracsf solracsf added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 10, 2025
@solracsf solracsf marked this pull request as ready for review March 10, 2025 17:28
@solracsf solracsf requested a review from a team as a code owner March 10, 2025 17:28
@solracsf solracsf requested review from ArtificialOwl, artonge and sorbaugh and removed request for a team March 10, 2025 17:28
@solracsf
Copy link
Member Author

/backport to stable31

@solracsf
Copy link
Member Author

/backport to stable30

@kesselb

This comment was marked as outdated.

@kesselb kesselb requested a review from susnux March 10, 2025 17:49
@kesselb kesselb added the bug label Mar 10, 2025
susnux

This comment was marked as outdated.

@susnux susnux dismissed their stale review March 10, 2025 17:54

Too quickly

@susnux

This comment was marked as outdated.

@susnux susnux self-requested a review March 10, 2025 17:55
@solracsf
Copy link
Member Author

solracsf commented Mar 10, 2025

EDIT: Applied the fix to the folder creation logic.

@solracsf solracsf force-pushed the appStoreCacheFolder branch from e364d09 to 124985c Compare March 10, 2025 18:06
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf force-pushed the appStoreCacheFolder branch from 124985c to 659747e Compare March 10, 2025 18:11
@solracsf solracsf requested a review from kesselb March 10, 2025 18:12
@solracsf solracsf changed the title fix(AppDiscover): Ensure created cache folder is safe-chars only fix(AppDiscover): Strip double-quotes from folder name Mar 11, 2025
@solracsf solracsf enabled auto-merge March 11, 2025 16:47
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe? ;) I find getEtag and etag a bit weird.

Comment on lines +134 to +135
$getEtag = $this->discoverFetcher->getETag() ?? date('Y-m');
$etag = trim($getEtag, '"');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$getEtag = $this->discoverFetcher->getETag() ?? date('Y-m');
$etag = trim($getEtag, '"');
$etag = $this->discoverFetcher->getETag() ?? date('Y-m');
$cacheFolderName = trim($getEtag, '"');

@solracsf solracsf merged commit bbd3a3c into master Mar 11, 2025
190 checks passed
@solracsf solracsf deleted the appStoreCacheFolder branch March 11, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Remote images in discover section in AppStore not loading if Windows filename compatibility is enabled
3 participants