-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable29] fix(lookup-server): disable when not using global scale #51407
Conversation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
9413c9d
to
21bbb61
Compare
@@ -1039,8 +1039,10 @@ | |||
if ($this->gsConfig->isGlobalScaleEnabled()) { | |||
return true; | |||
} | |||
$result = $this->config->getAppValue('files_sharing', 'lookupServerEnabled', 'yes'); | |||
return ($result === 'yes'); | |||
$result = $this->config->getAppValue('files_sharing', 'lookupServerEnabled', 'no') === 'yes'; |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
@@ -1054,8 +1056,10 @@ | |||
if ($this->gsConfig->isGlobalScaleEnabled()) { | |||
return false; | |||
} | |||
$result = $this->config->getAppValue('files_sharing', 'lookupServerUploadEnabled', 'yes'); | |||
return ($result === 'yes'); | |||
$result = $this->config->getAppValue('files_sharing', 'lookupServerUploadEnabled', 'no') === 'yes'; |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
/backport to stable28 |
/backport to stable27 |
/backport to stable26 |
/backport to stable25 |
/backport to stable24 |
/backport to stable23 |
/backport to stable22 |
/backport to stable28 |
/backport to stable27 |
/backport to stable26 |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/51407/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4ec1edb8 e674631f 92c48d03 21bbb61a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51407/stable28 Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/51407/stable28') Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to stable28 |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/51407/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4ec1edb8 e674631f 92c48d03 21bbb61a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51407/stable28 Error: Failed to clone repository: git is not defined Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to stable28 |
1 similar comment
/backport to stable28 |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/51407/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4ec1edb8 e674631f 92c48d03 21bbb61a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51407/stable28 Error: Failed to clone repository: Cannot use simple-git on a directory that does not exist Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to stable28 |
/backport to stable27 |
/backport to stable26 |
/backport to stable25 |
/backport to stable24 |
/backport to stable23 |
/backport to stable22 |
Backport of #51404
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.