-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix(GenerateBlurhashMetadata): Suppress imagescale errors #51433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(GenerateBlurhashMetadata): Suppress imagescale errors #51433
Conversation
|
@umgfoin we use a rebase workflow, so please don't merge the master branch into your branch (and it's really not necessary unless there are conflicts which is very unlikely with such a small change). You need to format your commit message according to https://www.conventionalcommits.org/en/v1.0.0/, so something like |
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
Suppress errors in imagescale during file-scans: Most of these errors are caused by out of range x/y-dims. Triggering un unhandled exception, metadata-generation aborts at this point (e.g. occ files:scan --generate-metadata), effectively preventing these images from being added to photos or maps. This problem might be the root cause for an issue described here: nextcloud/photos#2768 Signed-off-by: umgfoin <umgfoin@users.noreply.github.com>
1602501 to
b3b2c68
Compare
|
@skjnldsv can you approve and force-merge? Cypress doesn't need to run for this change. |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Suppress errors in
GenerateBlurhashMetadata::resizedImageFromFile(...)imagescaleduring file-scans:Most of these errors are caused by out of range x/y-dims.
Triggering un unhandled exception, metadata-generation aborts at this point (e.g. occ files:scan --generate-metadata), effectively preventing these images from being added to photos or maps.
This problem might be the root cause for an issue described in nextcloud/photos#2768).
TODO
Checklist