Skip to content

Conversation

@umgfoin
Copy link
Contributor

@umgfoin umgfoin commented Mar 12, 2025

  • Resolves: #

Summary

Suppress errors in GenerateBlurhashMetadata::resizedImageFromFile(...) imagescale during file-scans:
Most of these errors are caused by out of range x/y-dims.

Triggering un unhandled exception, metadata-generation aborts at this point (e.g. occ files:scan --generate-metadata), effectively preventing these images from being added to photos or maps.

This problem might be the root cause for an issue described in nextcloud/photos#2768).

TODO

  • ...

Checklist

@umgfoin umgfoin requested a review from a team as a code owner March 12, 2025 11:34
@umgfoin umgfoin requested review from nfebe, provokateurin and yemkareems and removed request for a team March 12, 2025 11:34
@umgfoin umgfoin changed the title GenerateBlurhashMetadata.php: Supress imagescale errors GenerateBlurhashMetadata.php: Suppress imagescale errors Mar 12, 2025
@umgfoin umgfoin requested a review from joshtrichards March 12, 2025 11:46
@provokateurin
Copy link
Member

@umgfoin we use a rebase workflow, so please don't merge the master branch into your branch (and it's really not necessary unless there are conflicts which is very unlikely with such a small change). You need to format your commit message according to https://www.conventionalcommits.org/en/v1.0.0/, so something like fix(GenerateBlurhashMetadata): Suppress imagescale errors .

@provokateurin
Copy link
Member

/backport to stable31

@provokateurin
Copy link
Member

/backport to stable30

@provokateurin
Copy link
Member

/backport to stable29

@umgfoin umgfoin changed the title GenerateBlurhashMetadata.php: Suppress imagescale errors fix(GenerateBlurhashMetadata): Suppress imagescale errors Mar 12, 2025
Suppress errors in imagescale during file-scans:
Most of these errors are caused by out of range x/y-dims.

Triggering un unhandled exception, metadata-generation aborts at this point  (e.g. occ files:scan --generate-metadata), effectively preventing these images from being added to photos or maps.

This problem might be the root cause for an issue described here:
nextcloud/photos#2768

Signed-off-by: umgfoin <umgfoin@users.noreply.github.com>
@umgfoin umgfoin force-pushed the PR-umgfoin-fix-image-metadata-generation branch from 1602501 to b3b2c68 Compare March 12, 2025 14:44
@provokateurin provokateurin requested a review from skjnldsv March 12, 2025 15:07
@provokateurin
Copy link
Member

@skjnldsv can you approve and force-merge? Cypress doesn't need to run for this change.

@umgfoin umgfoin requested a review from tacruc March 21, 2025 08:08
@skjnldsv skjnldsv merged commit d171360 into nextcloud:master Mar 26, 2025
177 of 180 checks passed
@welcome
Copy link

welcome bot commented Mar 26, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants