Remove files and enrypted folders from "Move or copy" dialog window #51532
Conversation
…olders from dialog
…files-and-enrypted-folders
memurats
requested review from
artonge and
susnux
and removed request for
a team
|
Copy of #51484 applied to the master branch. |
Check nodes for CREATE permission
|
@memurats Can you compile and signoff you commit? |
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
|
/compile |
|
Unfortunately compile doesn't work on forks. Should i push the branch upstream? |
| // We don't want to show the current nodes in the file picker | ||
| return !fileIDs.includes(n.fileid) | ||
| }) | ||
| .setFilter((n: Node) => (n.permissions & Permission.CREATE) === Permission.CREATE) |
There was a problem hiding this comment.
I think this does not work. Because you can have readonly root directories with external mounts that allow writing / groupfolder ACL.
So we should not filter directories without create permission as this also blocks navigating to perfectly valid ones.
I think we should filter for folder here to implement #50199
And then we need to disable the select button if CREATE is missing, but not hide the folder completely.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Hi @memurats, thank you so much for the contribution! :) A small note – in the issue, the design suggestion was to grey the files out rather than hide them completely.
This is important to give some context, and also to not make people think their files are gone.
|
Proposal that grays files out: #55796 |
|
Resolved with #55796 |
5 participants
In the context of the "Move or copy file" dialog it doesn't make sense to show all other files in the list or encrypted folders.
In order to improve clarity and usability, these should be filtered out.