perf(cache): force Firefox to send cache headers #51761
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`immutable` header is only supported by Firefox and Safari. When the resource is stale, Firefox don't send `If-None-Match` and `If-Not-Modified-Since` headers. This commit force Firefox to send these headers when resources are stale. Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
perf/force-sending-ifnonematch
branch
from
15fb17c to
b83a4b5
Compare
Altahrim
requested review from
ArtificialOwl,
skjnldsv and
yemkareems
and removed request for
a team
skjnldsv
approved these changes
Mar 28, 2025
Member
|
Has this been tested? I mean, the Since immutable tells browser not to check in the first place, it should never reaches a state where Correct me if I'm wrong. |
Collaborator
Author
|
It was tested but it seems more related to time than headers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
immutableheader is only supported by Firefox and Safari. When the resource is stale, Firefox don't sendIf-None-MatchandIf-Not-Modified-Sinceheaders.This commit force Firefox to send these headers when resources are stale.
Checklist