Skip to content

Conversation

@Phreeman33
Copy link
Contributor

@Phreeman33 Phreeman33 commented Apr 2, 2025

Summary

This PR builds upon #42534 for fixes an issue where Chinese character avatars were not displaying properly. It also applies fonts tailored to the regional variations in Chinese writing conventions. The code was modified by a noob and has only undergone basic testing, so further testing and review may be necessary.

Screenshots

\u89d2 in SC
角(SC)
\u89d2 in TC/HK/JP/KR
角(TC HK JP KR)
\u8005 in KR
者(KR)
\u8005 in SC/TC/HK/JP
者(SC TC HK JP)
\u8aaa in JP/KR
說(JP KR)
\u8aaa in SC/TC/HK
說(SC TC HK)

TODO

  • ...

Checklist

@Phreeman33 Phreeman33 requested a review from a team as a code owner April 2, 2025 05:50
@Phreeman33 Phreeman33 requested review from ArtificialOwl, skjnldsv and yemkareems and removed request for a team April 2, 2025 05:50
@susnux susnux added bug 3. to review Waiting for reviews feature: language/translations (l10n/i18n) Localization and translation matters feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Apr 2, 2025
@susnux susnux added this to the Nextcloud 32 milestone Apr 2, 2025
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Phreeman33 could you please revert all other changes to keep the abstract getDisplayName method?
The only changes needed in this PR are:

  • getFont
  • generateAvatar
  • the regular fonts

@Phreeman33
Copy link
Contributor Author

@susnux
Done! Please review the code.

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv
Copy link
Member

skjnldsv commented Aug 1, 2025

@susnux anything else you think needs to be addressed ?

Signed-off-by: Phreeman33 <12772373+Phreeman33@users.noreply.github.com>
@susnux
Copy link
Contributor

susnux commented Aug 6, 2025

anything else you think needs to be addressed ?

@skjnldsv yes the psalm error was related. I fixed that one and now it should be fine.
Tested it also locally and it seems to work perfectly ✔️

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested review from kesselb and skjnldsv August 6, 2025 10:54
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv merged commit b514d75 into nextcloud:master Aug 6, 2025
180 of 185 checks passed
@susnux
Copy link
Contributor

susnux commented Aug 6, 2025

@Phreeman33 thank you for your PR ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: language/translations (l10n/i18n) Localization and translation matters feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

First Character of Chinese or other multi-bytes characters display name

4 participants