-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: display chinese character avatar #51855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Phreeman33 could you please revert all other changes to keep the abstract getDisplayName method?
The only changes needed in this PR are:
getFontgenerateAvatar- the regular fonts
d4f4176 to
48b1520
Compare
|
@susnux |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@susnux anything else you think needs to be addressed ? |
Signed-off-by: Phreeman33 <12772373+Phreeman33@users.noreply.github.com>
@skjnldsv yes the psalm error was related. I fixed that one and now it should be fine. |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
@Phreeman33 thank you for your PR ✨ |
Summary
This PR builds upon #42534 for fixes an issue where Chinese character avatars were not displaying properly. It also applies fonts tailored to the regional variations in Chinese writing conventions. The code was modified by a noob and has only undergone basic testing, so further testing and review may be necessary.
Screenshots
\u89d2 in SC






\u89d2 in TC/HK/JP/KR
\u8005 in KR
\u8005 in SC/TC/HK/JP
\u8aaa in JP/KR
\u8aaa in SC/TC/HK
TODO
Checklist