[stable31] fix(files_sharing): Show remote shares as external #52498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/compile amend |
nfebe
approved these changes
Apr 28, 2025
nextcloud-command
force-pushed
the
backport/52423/stable31
branch
from
90d6036 to
f8c65d7
Compare
|
as discussed with @nfebe, please hold this backport until discussion about customers impact have happened 🙏 |
AndyScherzinger
requested changes
Apr 28, 2025
Member
AndyScherzinger
left a comment
AndyScherzinger
left a comment
There was a problem hiding this comment.
needs a config flag to switch the behavior to have this in "internal" shares
Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
backport/52423/stable31
branch
from
f8c65d7 to
5788dfa
Compare
Contributor
|
/compile |
Replaced multiple Array.filter() calls with a single loop to improve performance. This avoids redundant iterations over the shares array and categorizes them more efficiently. Signed-off-by: nfebe <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
nfebe
force-pushed
the
backport/52423/stable31
branch
from
5788dfa to
6873632
Compare
Contributor
|
Included : #52511 |
Contributor
|
/compile |
…g input - Fix autoloading for new `ConfigLexicon` - Ensure that sharing input in sharing tab respect `show-federated-shares-as-internal`: This is important, because when federated shares are shown as internal the users should add them from the internal shares section Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nfebe
force-pushed
the
backport/52423/stable31
branch
from
e07c389 to
d616a73
Compare
AndyScherzinger
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #52423
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.