Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme logo position and shape #525

Merged
merged 4 commits into from
Jul 26, 2016
Merged

Conversation

jospoortvliet
Copy link
Member

@jospoortvliet jospoortvliet commented Jul 22, 2016

Fix from #344 (comment)

  • fix logo in top bar
  • fix logo on login
    Working:
  • logo's that are higher than wide:
    spectacle i10431
    spectacle p10431
  • square-ish ones:
    spectacle n10431
    spectacle q10431

Still broken:

  • upon first apply, the logo is stretched. Can't figure out why, a reload fixes it and makes it look good.
    spectacle e10431
  • logo's which are wider are top-aligned, can't get them to vertically center:
    spectacle m10376

I can't figure out how to fix those. Leave it up to somebody with actual CSS fu.

@mention-bot
Copy link

@jospoortvliet, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @schiessle and @juliushaertl to be potential reviewers

@MorrisJobke
Copy link
Member

cc @jancborchardt

make the logo look good on the login page
@jospoortvliet jospoortvliet changed the title Update themingcontroller.php Fix theme logo position and shape Jul 22, 2016
@LukasReschke
Copy link
Member

Awesome. I'll hijack to fix the unit tests, @jospoortvliet :-)

@LukasReschke LukasReschke self-assigned this Jul 22, 2016
@LukasReschke LukasReschke added this to the Nextcloud 11.0 milestone Jul 22, 2016
@LukasReschke LukasReschke added the 2. developing Work in progress label Jul 22, 2016
@LukasReschke LukasReschke removed their assignment Jul 22, 2016
@LukasReschke
Copy link
Member

Tests adjusted at 8457c61, now I'll leave that to the CSS gurus 😉

@juliusknorr
Copy link
Member

I'll take over to fix the remaining css issues.

@juliusknorr
Copy link
Member

juliusknorr commented Jul 25, 2016

Should be done:

  • Fixed preview alignment
  • wider logos are now centered

I guess this is now ready for review.

@juliusknorr juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 25, 2016
@go2sh
Copy link
Contributor

go2sh commented Jul 25, 2016

Backport would be nice.

@MorrisJobke
Copy link
Member

Tested and works 👍

@MorrisJobke
Copy link
Member

@rullzer @Mar1u5 @nickvergessen @schiessle Review would be nice :)

@schiessle
Copy link
Member

looks good 👍

@schiessle schiessle added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 26, 2016
@nickvergessen nickvergessen merged commit cc5ddcf into master Jul 26, 2016
@nickvergessen nickvergessen deleted the fix-theme-logo-position branch July 26, 2016 08:46
@MorrisJobke
Copy link
Member

MorrisJobke commented Jul 26, 2016

Backport would be nice.

cc @karlitschek

@karlitschek
Copy link
Member

cool. please backport 👍

@juliusknorr
Copy link
Member

I'll create a backport for this, just for Nextcloud 10 or also for Nextcloud 9 @karlitschek @MorrisJobke

@karlitschek
Copy link
Member

i think both would be good

@jancborchardt
Copy link
Member

Awesome work @juliushaertl! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: theming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants