Use realpath to obtain the webroot.

[derkostka]

Use realpath to get the correct webroot path, even if it is symlinked. Thanks @sileht: https://gist.github.com/sileht/5753118ee048352778c2a0c5b23ea47d

[mention-bot]

@derkostka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @skjnldsv, @rullzer and @bartv2 to be potential reviewers.

[derkostka]

Please review !

This solves the issue of not finding the webroot in case that it is symlinked, see #5057

[pongraczi]

For me it is working in production since first published the workaround by the original author.

[jospoortvliet]

Would be nice to get in 12.0.1 @LukasReschke so the Nextcloud Box can move to 12

To check, @kyrofa does this solve your problem for the Nextcloud Box?

[kyrofa]

@jospoortvliet indeed this seems to make the file app usable once again. However, I still see the odd loading indicator when I initially visit it (to create the admin user/install nextcloud). Note that I've entered nothing. I guess that may be due to something else.

[kyrofa]

I also still see these in my Firefox dev console:

[pachulo]

In Chrome console the warnings that @kyrofa talked about are more concise:

Resource interpreted as Stylesheet but transferred with MIME type text/html: "http://localhost/index.php/apps/files"

[derkostka]

And was it working fine for you without that change ?

[pachulo]

no @derkostka , at least for me it was the same before your change

[kyrofa]

Indeed, @derkostka these issues happened without this PR, I just thought they were all due to the same issue, and apparently they're not. Or they might be and we're missing a realpath somewhere, who knows.

[derkostka]

I just tested it myself, #5289 seems to be a different topic: There, a Folder within the WebRoot is located elsewhere. This patch does not help there.

@jospoortvliet @rullzer : Please review & merge so that at least this part works again. Maybe the original author of the SCSS change can have another look at #5289

[jospoortvliet]

We really need this in 12.0.1 so the Nc box can move forward with 12...

[nickvergessen]

Can someone describe what exactly is symlinked?

[derkostka]

The patch helps if the webroot (the folder given in the config) got symlinked

So in the config.php: /var/www/nextcloud

[pongraczi]

Example:
/var/www/cbox.palyazatnelkul.hu -> /var/www/clients/client3/web15/

I use ispconfig3 and its filesystem layout. Webroot is, using the example above:
/var/www/cbox.palyazatnelkul.hu/web which is under the symlink.

[juliusknorr]

👍 I could reproduce the issue and this PR works.

[juliusknorr]

@derkostka Can you add a signoff message to your commits and maybe squash them into one?

https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md#sign-your-work might be helpful for that. 😉

[codecov]

Codecov Report

Merging #5252 into master will increase coverage by 0.02%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #5252      +/-   ##
============================================
+ Coverage     54.14%   54.16%   +0.02%     
+ Complexity    22345    22302      -43     
============================================
  Files          1380     1380              
  Lines         85551    85395     -156     
  Branches       1329     1321       -8     
============================================
- Hits          46323    46256      -67     
+ Misses        39228    39139      -89

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Template/CSSResourceLocator.php	0% <0%> (ø)	27 <0> (ø)	⬇️
lib/private/Template/ResourceLocator.php	64.81% <100%> (ø)	20 <0> (ø)	⬇️
lib/private/App/CodeChecker/InfoChecker.php	69.56% <0%> (-9.16%)	24% <0%> (+9%)
apps/systemtags/js/systemtagsinfoview.js	93.22% <0%> (-5.06%)	0% <0%> (ø)
lib/private/URLGenerator.php	75.67% <0%> (-1.96%)	46% <0%> (-18%)
core/js/systemtags/systemtagsinputfield.js	81.18% <0%> (-1.62%)	0% <0%> (ø)
apps/dav/lib/Connector/Sabre/BearerAuth.php	85.71% <0%> (-1.25%)	5% <0%> (-1%)
core/js/js.js	61.19% <0%> (-0.64%)	0% <0%> (ø)
lib/private/Template/SCSSCacher.php	68.85% <0%> (-0.51%)	34% <0%> (-1%)
apps/files/lib/Controller/ViewController.php	75.96% <0%> (-0.36%)	17% <0%> (-1%)
... and 38 more

[derkostka]

Done. @juliushaertl Thx

[MorrisJobke]

Works here 👍

[MorrisJobke]

@derkostka Could you prepare a PR against stable12? Thanks

[derkostka]

Sure: #5507
(i am getting used to GitHub now)

[kyrofa]

Nice, you can see that it's much better using the edge snap, which uses the daily master tarball:

$ sudo snap install nextcloud --channel=edge

Contrast that to the daily 12 snap (since #5507 hasn't landed yet):

$ sudo snap install nextcloud --channel=12/edge

And you'll see how terrible it is.

[jospoortvliet]

@derkostka you're a hero, thanks a lot for the work on this!