reword sessions to security in personal settings #5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
nickvergessen,
jancborchardt and
ChristophWurst
settings/templates/personal.php
Outdated
| <p class="settings-hint hidden-when-empty"><?php p($l->t('Web, desktop and mobile clients currently logged in to your account.'));?></p> | ||
| <div id="security" class="section"> | ||
| <h2><?php p($l->t('Security'));?></h2> | ||
| <p class="settings-hint hidden-when-empty"><?php p($l->t('Web, desktop mobile clients and app specific passwords that currently have access to your account.'));?></p> |
There was a problem hiding this comment.
missing , between desktop and mobile?
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
personal-sessions-renamwe
branch
from
61eeabe to
340fdc1
Compare
Codecov Report
@@ Coverage Diff @@
## master #5267 +/- ##
=========================================
Coverage ? 54.17%
Complexity ? 22302
=========================================
Files ? 1380
Lines ? 85383
Branches ? 1321
=========================================
Hits ? 46257
Misses ? 39126
Partials ? 0
|
MorrisJobke
approved these changes
Jun 6, 2017
ChristophWurst
approved these changes
Jun 7, 2017
|
Please backport. |
|
Please remove the backporten label once the backporten PR is opened ;) |
|
Cool! :) Simple wording fix which makes things more understandable. |
blizzz
added a commit
that referenced
this pull request
Jun 16, 2017
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
added a commit
that referenced
this pull request
Jun 23, 2017
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #5166 (comment)